Unused fields in a struct should not be reported as errors #12

New issue

Closed

opened 2025-08-17 12:33:28 +00:00 by zupa · 2 comments

zupa commented

2025-08-17 12:33:28 +00:00

Static analysis misses the use of s in:

(I wanted to implement a substring() function, this is a minimized code example.)

Code:

import io

main() {
	foo("hello world")
}

foo(s string) {
	_(s.ptr[0])
}

_(_ any) {}

Error:

tests/return-string.q:7:5

    foo(s string) {
        ┬
        ╰─ Unused value 's'

Static analysis misses the use of `s` in: (I wanted to implement a substring() function, this is a minimized code example.) Code: ``` import io main() { foo("hello world") } foo(s string) { _(s.ptr[0]) } _(_ any) {} ``` Error: ``` tests/return-string.q:7:5 foo(s string) { ┬ ╰─ Unused value 's' ```

👍 1

ed commented

2025-08-17 12:49:29 +00:00

Owner

Fixed in cli/q@049498c96b.

Test is ignore-unused-field.q

Fixed in https://git.urbach.dev/cli/q/commit/049498c96bb4fdb047f92af0dd3b4cc9fae69ef6. Test is [ignore-unused-field.q](https://git.urbach.dev/cli/q/src/branch/main/tests/ignore-unused-field.q)

ed added spent time

2025-08-17 12:49:42 +00:00

15 minutes

ed changed title from ~~Unused value 's'~~ to "Unused value" error for unused fields in a struct should be ignored

2025-08-17 12:51:57 +00:00

ed changed title from ~~"Unused value" error for unused fields in a struct should be ignored~~ to Unused fields in a struct should not be reported as errors

2025-08-17 12:53:54 +00:00

ed added the

bug

label

2025-08-17 12:54:35 +00:00

zupa commented

2025-08-17 13:43:26 +00:00

Author

Thx!